Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815135 --- Comment #3 from Julio Merino <jmmv@xxxxxxxxxxxxx> 2012-05-01 21:29:58 EDT --- Thanks for the review. I have uploaded a new copy of the spec and srpm files to the same location. The output of rpmlint on all the files is now: atf.spec: W: invalid-url Source0: http://kyua.googlecode.com/files/atf-0.15.tar.gz HTTP Error 404: Not Found atf.src: W: invalid-url Source0: http://kyua.googlecode.com/files/atf-0.15.tar.gz HTTP Error 404: Not Found atf.x86_64: W: devel-file-in-non-devel-package /usr/bin/atf-config 9 packages and 1 specfiles checked; 0 errors, 3 warnings. Things I have changed: - Added the common_description variable. It's a pity that the first line of the text has to be listed along the %define directive, as that pushes the line over the 80 column boundary. Putting a \ in the first line causes a spurious blank line to appear at the beginning of the descriptions, which I find ugly. - Added missing %defattr sections. - Added %doc lines to libatf-c, libatf-c++ and libatf-sh. I know you mentioned that because everything depends on libatf-c, only libatf-c had to include these. However, these cross-dependencies among the libatf-* packages are a weird artifact, and the resulting binary packages should not rely on them. Koji results: http://koji.fedoraproject.org/koji/taskinfo?taskID=4043303 -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review