Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=815135 Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #4 from Michel Alexandre Salim <michel+fdr@xxxxxxxxxxxx> 2012-05-03 07:21:50 EDT --- As (In reply to comment #3) > - Added the common_description variable. It's a pity that the first line of > the text has to be listed along the %define directive, as that pushes the line > over the 80 column boundary. Putting a \ in the first line causes a spurious > blank line to appear at the beginning of the descriptions, which I find ugly. > That's the same problem with Haskell packages, don't worry about it. > - Added missing %defattr sections. Actually this is no longer necessary: http://fedoraproject.org/wiki/Packaging:Guidelines#File_Permissions RHEL 5 already has rpm 4.4, so unless you really want to target RHEL 4 as well, you only need defattr if you need some unusual permissions > - Added %doc lines to libatf-c, libatf-c++ and libatf-sh. I know you mentioned > that because everything depends on libatf-c, only libatf-c had to include > these. However, these cross-dependencies among the libatf-* packages are a > weird artifact, and the resulting binary packages should not rely on them. > > Koji results: http://koji.fedoraproject.org/koji/taskinfo?taskID=4043303 Sounds good, I was only suggesting the bare minimum. APPROVED -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review