Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=809882 --- Comment #9 from Tim Bielawa <tbielawa@xxxxxxxxxx> 2012-05-01 21:16:01 EDT --- (In reply to comment #8) > Seems the license is wrong, it should be GPLv3+, not GPLv3 ( ie, the "or any > later" clause ). Good call! Fixed that. > The file used in src.rpm do not seems to be the same as the one upstream on > github : > > $ file ansible-0.3.tar.gz /tmp/ansible-0.3.tar.gz > ansible-0.3.tar.gz: gzip compressed data, was "dist/ansible-0.3.tar", last > modified: Mon Apr 30 18:30:36 2012, max compression > /tmp/ansible-0.3.tar.gz: gzip compressed data, was "ansible-0.3.tar", from > Unix, last modified: Tue Apr 24 04:18:05 2012, max compression > > ( the 2nd is the one from github, the first is the one from the src.rpm ) > I guess that's because you updated the spec in the tarball, and added the > LICENSE. > > "Packages should try to preserve timestamps of original installed > files.", I think that the cp invocation fail this part of the guideline > ( https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps ) I see what I did. Instead of using the sources we published on github I was using a fresh 'make sdist' copy. To make sure I didn't mess anything up with the sources this time I copied the spec file out of the tree to a temp directory and put the github sources into ~/rpmbuild/SOURCES and *then* ran `rpmbuild -bs`. Result is a fresh srpm built off of the upstream sources (Which includes the proper license file). SRPM: http://people.redhat.com/~tbielawa/ansible/ansible-0.3.1-1.fc16.src.rpm Spec: http://people.redhat.com/~tbielawa/ansible/ansible.spec Sums (for your pleasure): http://people.redhat.com/~tbielawa/ansible/ansible.asc Thanks for taking the time to review this Michael! -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review