[Bug 809882] Review Request: ansible - Minimal SSH command and control

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=809882

--- Comment #8 from Michael Scherer <misc@xxxxxxxx> 2012-05-01 06:00:10 EDT ---
Seems the license is wrong, it should be GPLv3+, not GPLv3 ( ie, the "or any
later" clause ).

The file used in src.rpm do not seems to be the same as the one upstream on
github :

$ file ansible-0.3.tar.gz /tmp/ansible-0.3.tar.gz 
ansible-0.3.tar.gz:      gzip compressed data, was "dist/ansible-0.3.tar", last
modified: Mon Apr 30 18:30:36 2012, max compression
/tmp/ansible-0.3.tar.gz: gzip compressed data, was "ansible-0.3.tar", from
Unix, last modified: Tue Apr 24 04:18:05 2012, max compression

( the 2nd is the one from github, the first is the one from the src.rpm )
I guess that's because you updated the spec in the tarball, and added the
LICENSE.


"Packages should try to preserve timestamps of original installed
     files.", I think that the cp invocation fail this part of the guideline 
( https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps )

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]