Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806093 --- Comment #3 from Kalev Lember <kalevlember@xxxxxxxxx> 2012-04-06 16:00:34 EDT --- (In reply to comment #2) > %check > desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/glade.desktop > > I think this should be part of the regular %install section - do we even run > %check by default on builds ? Yes, %check is run by default for all builds, right after %install. I don't think there's any practical difference whether to put this at the end of %install or in %check. https://fedoraproject.org/wiki/Packaging/Guidelines#desktop-file-install_usage > %{_datadir}/gnome/help/glade/ > %{_datadir}/omf/glade/ > > If you pass --with-gnome to %find_lang, it should pick these up (and properly > decorate them with %lang) Fixed. > %files libs > %doc COPYING* > > I think it would be nice to ship COPYING in the main package as well. The licensing guidelines say that it's OK to put the license files in just one subpackage, provided that all other subpackages depend on the one that has license files. But sure, I guess it doesn't hurt to have multiple copies. Added COPYING* to the main package as well. https://fedoraproject.org/wiki/Packaging/LicensingGuidelines#Subpackage_Licensing Spec URL: http://kalev.fedorapeople.org/glade.spec SRPM URL: http://kalev.fedorapeople.org/glade-3.12.0-2.fc17.src.rpm * Fri Apr 06 2012 Kalev Lember <kalevlember@xxxxxxxxx> - 3.12.0-2 - Review fixes (#806093) - Use find_lang --with-gnome for including help files - Include license files also in the main package in addition to -libs -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review