Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=806093 Matthias Clasen <mclasen@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mclasen@xxxxxxxxxx --- Comment #2 from Matthias Clasen <mclasen@xxxxxxxxxx> 2012-04-06 15:22:26 EDT --- Preliminary comments: %check desktop-file-validate $RPM_BUILD_ROOT%{_datadir}/applications/glade.desktop I think this should be part of the regular %install section - do we even run %check by default on builds ? %{_datadir}/gnome/help/glade/ %{_datadir}/omf/glade/ If you pass --with-gnome to %find_lang, it should pick these up (and properly decorate them with %lang) %files libs %doc COPYING* I think it would be nice to ship COPYING in the main package as well. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review