[Bug 799023] Review Request: eot-utils - Tools to convert OTF/TTF to EOT font format + show its metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799023

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-03-02 03:44:13 EST ---
Review:
- koji build failed (f17)
->http://koji.fedoraproject.org/koji/taskinfo?taskID=3845922

+ source verified with upstream as (sha1sum)
7e8a68ba1ae4b533113e7965aa2cca133367f31f  eot-utilities-1.1.tar.gz
7e8a68ba1ae4b533113e7965aa2cca133367f31f  ../SOURCES/eot-utilities-1.1.tar.gz


Suggestions:
1)  you need to remove autoreconf from %build as this will pass the scratch
build on koji.

2) install section change from
rm -rf -- $RPM_BUILD_ROOT
make install-strip DESTDIR=$RPM_BUILD_ROOT

to
make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]