[Bug 799023] Review Request: eot-utils - Tools to convert OTF/TTF to EOT font format + show its metadata

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=799023

--- Comment #2 from Jan Pokorny <jpokorny@xxxxxxxxxx> 2012-03-02 06:50:07 EST ---
(In reply to comment #1)

> 1)  you need to remove autoreconf from %build as this will pass
> the scratch build on koji.

Agreed, I've just found [1] and it works well for me without it in
the mock environment.

(Otherwise, these BuildRequires would be needed: autoconf, automake, m4.)

> 2) install section change from
> rm -rf -- $RPM_BUILD_ROOT
> make install-strip DESTDIR=$RPM_BUILD_ROOT
> to
> make install DESTDIR=$RPM_BUILD_ROOT INSTALL="install -p"

The removal command comes from rpmdev-newspec.  If this is not needed
or it serves only to ensure everything is rebuilt properly when building
locally, bug against rpmdevtools should be filed.

Re: INSTALL="install -p" ... agreed.

Re: install-strip -> install:
I got it, it is a matter of postprocessing that will create separate
debuginfo package and actually strip the binaries.  (Interestingly,
"install-strip" will not do the stripping in this case either.)

[1] http://stackoverflow.com/a/7754416

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]