Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783149 --- Comment #5 from Petr Šabata <psabata@xxxxxxxxxx> 2012-01-20 06:21:03 EST --- (In reply to comment #4) > I see. Resuming. > > No XS code, noarch BuildArch is Ok. > > FIX: Remove perl(POE::Filter::Reference) from build-requires or make it > run-time dependency too (lib/POE/Component/Resolver.pm:219). > FIX: Remove perl(POE::Filter::Reference) from build-requires or make it > run-time dependency too (lib/POE/Component/Resolver.pm:218). > I've added POE::Filter::Reference and POE::Wheel::Run (which is what you meant, I suppose) to Requires. > TODO: Remove `perl(Scalar::Util) >= 1.23' from run-time dependencies. It's used > obviously nowhere in the code. Removed. > FIX: Build-Require `perl(POE::Component::Resolver::Sidecar)' for tests > (lib/POE/Component/Resolver.pm:15). Won't do. It's is provided by this package. > > FIX: Package does not build in F17 > (http://koji.fedoraproject.org/koji/taskinfo?taskID=3715139). > It looks like of-by-one error if $#got_families == 1 at $i declaration: > > my $i = $#got_families; > while ($i--) { > splice(@got_families, $i, 1) if ( > → $got_families[$i] == $got_families[$i+1] > ); > } > This test fails only in koji; the package works fine and all test pass in mock. I've disabled the failing test for now. -- Again, the updated package in available on the same URLs. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review