Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783149 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #6 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-20 08:28:55 EST --- Spec file changes: --- perl-POE-Component-Resolver.spec.old 2012-01-19 15:19:28.000000000 +0100 +++ perl-POE-Component-Resolver.spec 2012-01-20 12:17:43.000000000 +0100 @@ -7,6 +7,7 @@ URL: http://search.cpan.org/dist/POE-Component-Resolver/ Source0: http://www.cpan.org/authors/id/R/RC/RCAPUTO/POE-Component-Resolver-%{version}.tar.gz BuildArch: noarch +BuildRequires: perl(base) BuildRequires: perl(Carp) BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::MakeMaker) @@ -20,7 +21,8 @@ BuildRequires: perl(Test::More) >= 0.96 BuildRequires: perl(Time::HiRes) >= 1.9711 Requires: perl(POE) >= 1.311 -Requires: perl(Scalar::Util) >= 1.23 +Requires: perl(POE::Filter::Reference) +Requires: perl(POE::Wheel::Run) Requires: perl(Socket::GetAddrInfo) >= 0.19 Requires: perl(Storable) >= 2.18 Requires: perl(Time::HiRes) >= 1.9711 @@ -28,7 +30,6 @@ %{?perl_default_filter} %global __requires_exclude %{?__requires_exclude:__requires_exclude|}^perl\\(POE\\) -%global __requires_exclude %__requires_exclude|^perl\\(Scalar::Util\\) %global __requires_exclude %__requires_exclude|^perl\\(Socket::GetAddrInfo\\) %global __requires_exclude %__requires_exclude|^perl\\(Storable\\) %global __requires_exclude %__requires_exclude|^perl\\(Time::HiRes\\) @@ -51,10 +52,12 @@ %{_fixperms} %{buildroot}/* %check +# Remove resolver test which doesn't work in koji +rm -f t/01-basic.t make test %files -%doc CHANGES LICENSE README README.mkdn +%doc CHANGES LICENSE README %{perl_vendorlib}/* %{_mandir}/man3/* > TODO: BuildRequire `perl(base)' for tests (lib/POE/Component/Resolver.pm:18) +BuildRequires: perl(base) Ok. > TODO: Package only README or only REAMDE.mkdn. Their identical but formatting. %files -%doc CHANGES LICENSE README README.mkdn +%doc CHANGES LICENSE README Ok. > FIX: Remove perl(POE::Filter::Reference) from build-requires or make it > run-time dependency too (lib/POE/Component/Resolver.pm:219). > FIX: Remove perl(POE::Filter::Reference) from build-requires or make it > run-time dependency too (lib/POE/Component/Resolver.pm:218). +Requires: perl(POE::Filter::Reference) +Requires: perl(POE::Wheel::Run) Ok. > TODO: Remove `perl(Scalar::Util) >= 1.23' from run-time dependencies. It's > used obviously nowhere in the code. -Requires: perl(Scalar::Util) >= 1.23 Ok. > > FIX: Build-Require `perl(POE::Component::Resolver::Sidecar)' for tests > > (lib/POE/Component/Resolver.pm:15). > Won't do. It's is provided by this package. You are right. Ok. All tests pass. Ok. $ rpmlint perl-POE-Component-Resolver.spec ../SRPMS/perl-POE-Component-Resolver-0.914-1.fc17.src.rpm ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm perl-POE-Component-Resolver.src: W: spelling-error Summary(en_US) getaddrinfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US GetAddrInfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US getaddrinfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US subprocesses -> sub processes, sub-processes, processes perl-POE-Component-Resolver.noarch: W: spelling-error Summary(en_US) getaddrinfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US GetAddrInfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US getaddrinfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US subprocesses -> sub processes, sub-processes, processes perl-POE-Component-Resolver.noarch: E: incorrect-fsf-address /usr/share/doc/perl-POE-Component-Resolver-0.914/LICENSE 2 packages and 1 specfiles checked; 1 errors, 8 warnings. rpmlint is Ok. > TODO: Remove `perl(Scalar::Util) >= 1.23' from run-time dependencies. It's used > obviously nowhere in the code. $ rpm -q --requires -p ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm | sort |uniq -c 1 perl(base) 1 perl(bytes) 1 perl(Carp) 1 perl(Config) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(POE) >= 1.311 1 perl(POE::Component::Resolver::Sidecar) 1 perl(POE::Filter::Reference) 1 perl(POE::Wheel::Run) 1 perl(Socket) 1 perl(Socket::GetAddrInfo) >= 0.19 1 perl(Storable) >= 2.18 1 perl(strict) 1 perl(Time::HiRes) >= 1.9711 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. Binaries dependencies are resolvable. Ok. > > FIX: Package does not build in F17 > > (http://koji.fedoraproject.org/koji/taskinfo?taskID=3715139). > This test fails only in koji; the package works fine and all test pass in > mock. I've disabled the failing test for now. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3717450). Ok. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review