Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=783149 --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-19 10:47:13 EST --- I see. Resuming. No XS code, noarch BuildArch is Ok. FIX: Remove perl(POE::Filter::Reference) from build-requires or make it run-time dependency too (lib/POE/Component/Resolver.pm:219). FIX: Remove perl(POE::Filter::Reference) from build-requires or make it run-time dependency too (lib/POE/Component/Resolver.pm:218). TODO: Remove `perl(Scalar::Util) >= 1.23' from run-time dependencies. It's used obviously nowhere in the code. FIX: Build-Require `perl(POE::Component::Resolver::Sidecar)' for tests (lib/POE/Component/Resolver.pm:15). All tests pass. Ok. $ rpmlint perl-POE-Component-Resolver.spec ../SRPMS/perl-POE-Component-Resolver-0.914-1.fc17.src.rpm ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm perl-POE-Component-Resolver.src: W: spelling-error Summary(en_US) getaddrinfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US GetAddrInfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US getaddrinfo perl-POE-Component-Resolver.src: W: spelling-error %description -l en_US subprocesses -> sub processes, sub-processes, processes perl-POE-Component-Resolver.noarch: W: spelling-error Summary(en_US) getaddrinfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US GetAddrInfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US getaddrinfo perl-POE-Component-Resolver.noarch: W: spelling-error %description -l en_US subprocesses -> sub processes, sub-processes, processes perl-POE-Component-Resolver.noarch: E: incorrect-fsf-address /usr/share/doc/perl-POE-Component-Resolver-0.914/LICENSE 2 packages and 1 specfiles checked; 1 errors, 8 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm drwxr-xr-x 2 root root 0 Jan 19 16:11 /usr/share/doc/perl-POE-Component-Resolver-0.914 -rw-r--r-- 1 root root 6863 Sep 15 07:51 /usr/share/doc/perl-POE-Component-Resolver-0.914/CHANGES -rw-r--r-- 1 root root 18252 Sep 15 07:51 /usr/share/doc/perl-POE-Component-Resolver-0.914/LICENSE -rw-r--r-- 1 root root 9561 Sep 15 07:51 /usr/share/doc/perl-POE-Component-Resolver-0.914/README -rw-r--r-- 1 root root 7909 Sep 15 07:51 /usr/share/doc/perl-POE-Component-Resolver-0.914/README.mkdn -rw-r--r-- 1 root root 5122 Jan 19 16:11 /usr/share/man/man3/POE::Component::Resolver.3pm.gz -rw-r--r-- 1 root root 2357 Jan 19 16:11 /usr/share/man/man3/POE::Component::Resolver::Sidecar.3pm.gz drwxr-xr-x 2 root root 0 Jan 19 16:11 /usr/share/perl5/vendor_perl/POE drwxr-xr-x 2 root root 0 Jan 19 16:11 /usr/share/perl5/vendor_perl/POE/Component drwxr-xr-x 2 root root 0 Jan 19 16:11 /usr/share/perl5/vendor_perl/POE/Component/Resolver -rw-r--r-- 1 root root 19562 Sep 15 07:51 /usr/share/perl5/vendor_perl/POE/Component/Resolver.pm -rw-r--r-- 1 root root 2415 Sep 15 07:51 /usr/share/perl5/vendor_perl/POE/Component/Resolver/Sidecar.pm File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm |sort |uniq -c 1 perl(base) 1 perl(bytes) 1 perl(Carp) 1 perl(Config) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(POE) >= 1.311 1 perl(POE::Component::Resolver::Sidecar) 1 perl(Scalar::Util) >= 1.23 1 perl(Socket) 1 perl(Socket::GetAddrInfo) >= 0.19 1 perl(Storable) >= 2.18 1 perl(strict) 1 perl(Time::HiRes) >= 1.9711 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Remove `perl(Scalar::Util) >= 1.23' from run-time dependencies. It's used obviously nowhere in the code. $ rpm -q --provides -p ../RPMS/noarch/perl-POE-Component-Resolver-0.914-1.fc17.noarch.rpm |sort |uniq -c 1 perl(POE::Component::Resolver) = 0.914 1 perl-POE-Component-Resolver = 0.914-1.fc17 1 perl(POE::Component::Resolver::Sidecar) = 0.914 Binary provides are Ok. Binaries dependencies are resolvable. Ok. FIX: Package does not build in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3715139). It looks like of-by-one error if $#got_families == 1 at $i declaration: my $i = $#got_families; while ($i--) { splice(@got_families, $i, 1) if ( → $got_families[$i] == $got_families[$i+1] ); } Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' items, consider fixing `TODO' issues, and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review