Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773502 Michael Schwendt <mschwendt@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |mschwendt@xxxxxxxxx Flag| |fedora-review+ --- Comment #3 from Michael Schwendt <mschwendt@xxxxxxxxx> 2012-01-15 17:24:47 EST --- > AUTOMATED_TESTING=1 Confirmed. No questions about the example scripts are asked anymore. > Requires: perl(IO::Scalar) > +Requires: perl(Test::More) >= 0.98 http://fedoraproject.org/wiki/Packaging:Guidelines#Explicit_Requires Even if it may seem that it is specific to libraries only, it covers explicit Requires in general. Comments in the spec file, which explain the explicit Requires, are good packaging practice. * Please keep the spec %changelog accurate. Your updates to the spec invalidated the only %changelog entry about cpanspec usage. * A few more packages for the tests are available in Fedora already, btw, just in case you consider the tests worthwhile: perl-Text-CSV perl-Text-CSV_XS perl-Test-Pod perl-Test-Pod-Coverage perl-Spreadsheet-ParseExcel t/00_pod.t ..... ok t/01_pod.t ..... ok t/10_basics.t .. ok t/11_call.t .... ok t/20_csv.t ..... # Parser: Text::CSV_XS-0.82 t/20_csv.t ..... ok t/21_csv.t ..... ok t/22_csv.t ..... ok t/23_csv.t ..... ok t/24_csv.t ..... ok t/30_xls.t ..... # Parser: Spreadsheet::ParseExcel-0.59 t/30_xls.t ..... ok t/31_clr.t ..... ok t/32_fmt.t ..... ok t/33_misc.t .... ok t/34_dates.t ... ok t/35_perc.t .... ok t/36_xls.t ..... ok t/40_sxc.t ..... skipped: No SXC parser found t/45_ods.t ..... skipped: No SXC parser found t/46_clr.t ..... skipped: No OpenOffice ODS parser found t/50_sc.t ...... # Parser: Spreadsheet::Read-0.45 t/50_sc.t ...... ok t/51_sc.t ...... ok t/60_xlsx.t .... skipped: No M$-Excel parser found t/61_clr.t ..... skipped: No M$-Excel parser found t/62_fmt.t ..... skipped: No M$-Excel parser found t/63_misc.t .... skipped: No M$-Excel parser found t/64_dates.t ... skipped: No M$-Excel parser found t/65_perc.t .... skipped: No M$-Excel parser found All tests successful. * You get an 'APPROVED' from me, provided that you update the %changelog within pkg git and add comments to the explicit Requires. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review