[Bug 773502] Review Request: perl-Spreadsheet-read - universal API to read any spreadsheet

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=773502

Ralf Corsepius <rc040203@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |rc040203@xxxxxxxxxx

--- Comment #4 from Ralf Corsepius <rc040203@xxxxxxxxxx> 2012-01-16 02:46:26 EST ---
Requires:       perl(Test::More) >= 0.98
This Requires: is wrong. 

There is no run-time dependency between this package and Test::More:
# grep More Spreadsheet-Read-0.45/Read.pm

Requires:       perl(IO::Scalar)
I am not sure about this one. Looks like this is implemented as optional
run-time requirement, while it actually is a mandatory requirement.
I.e. I am inclined to believe this Requires: might be right.


...
t/40_sxc.t ..... skipped: No SXC parser found
t/45_ods.t ..... skipped: No SXC parser found
...
If I understand the code correctly, these warnings indicate that some optional
modules, these tests are trying exercise are not available.

I haven't checked all details, but in case of the 40_sxc.t,
Spreadsheet::ReadSXC seems to be required to exercise this test.
I'd recommend to also package such optional perl-modules and to BR: them.
This would assure these packages are tested at build-time and are (optionally)
available to users at run-time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]