Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=773502 --- Comment #2 from Mark Goodwin <mgoodwin@xxxxxxxxxx> 2012-01-12 16:24:05 EST --- (In reply to comment #1) thanks for looking at this > [Although I know a bit of Perl, I'm not a Perl packager, so I'm not up-to-date > on Fedora Perl Packaging]. I'm not either - this probably should be reviewed by someone who is. > * A plain src.rpm rebuild is interactive here: > .. > + /usr/bin/perl Makefile.PL INSTALLDIRS=vendor > Do you want to install 'xlscat' (Convert Spreadsheet to plain text or CSV) ? > [n] > > That's a blocker. Several more setup questions are asked. This ought to be > automatic with a default build config being applied. My koji builds didn't stall or ask any questions - they just worked, presumably using default answers. Reading Makefile.PL, it will not ask questions if AUTOMATED_TESTING=1 in the environment, so I've made that change in the spec (see diff below). > * There's a test-suite included, suitable for a %check section. "make test" > does something, but requires _at least_ perl-Test-Simple perl-Test-NoWarnings > and then still warns about further build requirements as well as skipped tests. ok, I added a few more build dependencies for the testing and added a %check section. Seems to work, and tolerate any missing spreadsheet parsers. I've copied the new spec and srpm up to the same location. Here's the diff : --- old/perl-Spreadsheet-Read.spec 2012-01-11 19:47:36.884021000 -0500 +++ perl-Spreadsheet-Read.spec 2012-01-12 16:16:58.166961000 -0500 @@ -11,8 +11,11 @@ BuildRequires: perl >= 0:5.006 BuildRequires: perl(ExtUtils::MakeMaker) BuildRequires: perl(IO::Scalar) +BuildRequires: perl(Test::NoWarnings) +BuildRequires: perl(Test::More) >= 0.98 Requires: perl(IO::Scalar) +Requires: perl(Test::More) >= 0.98 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) %description @@ -24,7 +27,7 @@ %setup -q -n Spreadsheet-Read-%{version} %build -%{__perl} Makefile.PL INSTALLDIRS=vendor +AUTOMATED_TESTING=1 %{__perl} Makefile.PL INSTALLDIRS=vendor make %{?_smp_mflags} %install @@ -37,6 +40,9 @@ %{_fixperms} $RPM_BUILD_ROOT/* +%check +make test + %clean rm -rf $RPM_BUILD_ROOT -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review