[Bug 771111] Review Request: ovirt-engine-sdk - SDK for oVirt-Engine platform

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=771111

--- Comment #16 from David Nalley <david@xxxxxxx> 2012-01-09 11:10:19 EST ---
Glad the tarball is out, that greatly simplifies things. 

I don't know how closely you are working with upstream - but typically release
is something that the distro handles e.g. if they have a choice in future
naming of their tarballs only include name and version, and let release be
handled by Fedora. 

RPM version should generally always match upstream versioning. There are some
exceptions, largely documented in this section: 
http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Package_Versioning

Release however tends to be distro specific - so every time you change the spec
file you'll increment the release. While it seems bothersome now, and the
problem you cite with including spec file is an issue. There are lots of builds
that will increment the changelog/release and you'll have no control over, so
for instance, there's a mass rebuild of all Fedora packages going on now (or
very shortly) for a new gcc version. That means an incremented release and an
additional changelog entry (and new builds of the software going out). Also
keep in mind that others (those in the provenpackager group) can touch your
packages, modify spec files, etc. So you might get $version-1 into the repo for
a given tag. Most folks who include a spec files make it a pretty generalized,
working spec file in the source repo. Sheepdog is a decent example of this: 
https://github.com/collie/sheepdog/blob/master/sheepdog.spec.in

Keep in mind you'll be checking your spec file into a package-specific git repo
and maintaining it there for Fedora and EPEL.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]