[Bug 665901] Review Request: perl-Gravatar-URL - Make URLs for Gravatars from an email address

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=665901

Petr Šabata <psabata@xxxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |psabata@xxxxxxxxxx

--- Comment #1 from Petr Šabata <psabata@xxxxxxxxxx> 2012-01-09 11:07:41 EST ---
I'm not a sponsor but my quick notes:
The package doesn't build in mock since you're missing some key dependencies
(Digest::MD5, to be specific).  You should also buildrequire Carp, and
Unicornify::URL, which is not in Fedora and has to be packaged first.
Also remove the explicit perl BR.

Moreover, Buildroot tag (line 9) and buildroot cleaning (lines 35, 45, 46) are
no longer needed in Fedora.  The same applies to %defattr (line 49).

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]