Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771111 --- Comment #17 from Ofer Schreiber <oschreib@xxxxxxxxxx> 2012-01-09 11:48:07 EST --- I think we're fine here, we don't include the spec file itself in the git/tarball, we include ovirt-engine-sdk.spec.in, which is pretty generalized, although we can do some better job there. About versioning - I think that if tarball version is 1.0-1, the first rpm will be 1.0-1 and we will add .1/2/3 in the end of the release for every additional build. anyhow, I didn't thought of adding changelog entries during this review (only afterwards), if it's required, I'll add it. Anything more I should do before starting the official review? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review