Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 --- Comment #3 from Bohuslav Kabrda <bkabrda@xxxxxxxxxx> 2012-01-03 07:56:05 EST --- - The package FTBTS [1]. Please do a Koji build before every review to see if it passes. -- You need to BR: rubygem(rspec-core) instead of rubygem(rspec). -- You also need to BR: rubygem(rack-test) for running the specs. - Could you specify what is the advantage of running the specs with "ruby -S rspec spec", when "rspec spec" suffices? This is not a blocker, but why not make things as simple as possible? - Do you intend to place the package into EPEL, too? If not, please remove the unnecessary BuildRoot tag (see [2] for more info). - Please be consistent in usage of macros for shell commands and the commands themselves. For example, you use both "%{__mkdir_p}" macro and "mkdir -p" command. So decide whether you want to use macros or commands and don't mix the two. - Consider excluding the cached gem, as it is not an unnecessary payload, not needed for RPM package. - Mark %{geminstdir}/License with %doc. - Move %{geminstdir}/README.md to the -doc subpackage, if it is not needed for runtime (which I believe it isn't) and mark it with %doc. - Also, mark %{gemdir}/doc/%{gemname}-%{version} with %doc. [1] http://koji.fedoraproject.org/koji/taskinfo?taskID=3615389 [2] https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review