Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771233 --- Comment #4 from Michal Fojtik <mfojtik@xxxxxxxxxx> 2012-01-03 11:09:52 EST --- (In reply to comment #3) Hi Bohuslav First thanks for reviewing this package! > - The package FTBTS [1]. Please do a Koji build before every review to see if > it passes. > -- You need to BR: rubygem(rspec-core) instead of rubygem(rspec). > -- You also need to BR: rubygem(rack-test) for running the specs. All done. > - Could you specify what is the advantage of running the specs with "ruby -S > rspec spec", when "rspec spec" suffices? This is not a blocker, but why not > make things as simple as possible? We used it in thin package. However this form sounds better and shorter for me. Fixed in -2. > - Do you intend to place the package into EPEL, too? If not, please remove the > unnecessary BuildRoot tag (see [2] for more info). This package will be imported to EPEL. I'll exclude BuildRoot from Fedora packages before import. > - Please be consistent in usage of macros for shell commands and the commands > themselves. For example, you use both "%{__mkdir_p}" macro and "mkdir -p" > command. So decide whether you want to use macros or commands and don't mix the > two. Done. > - Consider excluding the cached gem, as it is not an unnecessary payload, not > needed for RPM package. Done. > - Mark %{geminstdir}/License with %doc. Done, > - Move %{geminstdir}/README.md to the -doc subpackage, if it is not needed for > runtime (which I believe it isn't) and mark it with %doc. > - Also, mark %{gemdir}/doc/%{gemname}-%{version} with %doc. Actually I don't think marking -doc subpackage files with %doc is necessary. Could you point me to a guideline where this is required? ===================================================== koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3615827 rpmlint: rubygem-rack-protection.noarch: I: enchant-dictionary-not-found en_US 1 packages and 0 specfiles checked; 0 errors, 0 warnings. * Mon Jan 03 2012 Michal Fojtik <mfojtik@xxxxxxxxxx> - 1.2.0-2 - Fixed BR - Marked documentation file with doc tag - Changed the way how to run rspec tests -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review