Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=771295 Vít Ondruch <vondruch@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review+ --- Comment #2 from Vít Ondruch <vondruch@xxxxxxxxxx> 2012-01-03 07:55:25 EST --- * Test suite - Please consider execution of the test suite in the %check section? It seems there are specs available upstream. * rpmlint output - rpmlint complains about permissions of .spec file: rubygem-delorean.src: W: strange-permission rubygem-delorean.spec 0666L A file that you listed to include in your package has strange permissions. Usually, a file should have 0644 permissions. Otherwise, I have no other comments, so I APPROVE the package. Please fix the rpmlint before import of the package and consider execution of the test suite. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review