Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757657 --- Comment #2 from Marcela Mašláňová <mmaslano@xxxxxxxxxx> 2012-01-02 11:06:11 EST --- (In reply to comment #1) New version of the specfile. http://mmaslano.fedorapeople.org/review/perl-Wx-Scintilla.spec > Source tar ball is original. Ok. > Summary verified from lib/Wx/Scintilla.pm. Ok. > > FIX: License tag does not cover bundled Scintilla sources > (wx-scintilla/src/scintilla/). I can attach an email from the upstream if comments in the specfile are not enough. > FIX: Do not bundle Scintilla (wx-scintilla/src/scintilla/). Scintilla must be bundled. According to upstream development of the main source is slow and it doesn't have some features, which they need. So, they've also changed some files for specific usage in Padre. qtscintilla made the same thing, but for their own use. Another reason is the portability. > > TODO: Augment description with other paragraphs from lib/Wx/Scintilla.pm POD. > The first one does not define what this package delivers. Fixed. > > FIX: Build-require perl(Exporter) (lib/Wx/Scintilla/Constant.pm:12) > FIX: Build-require perl(Caro) (lib/Wx/Scintilla.pm:6) > FIX: Build-require perl(XSLoader) (lib/Wx/Scintilla.pm:8) > > FIX: Build-require perl(base) (t/lib/Tests_Helper.pm:197) > FIX: Build-require perl(Wx::App) (t/lib/Tests_Helper.pm:197) > FIX: Build-require perl(Wx::Frame) (t/lib/Tests_Helper.pm:218) > FIX: Build-require perl(Wx::Event) (t/03_editor.t:27) > FIX: Build-require perl(lib) (t/02_inheritance.t:10) > Fixed. > TODO: Do not %doc-package META.json (as you do not package META.yml) > Fixed. > All tests pass. Ok. > > $ rpmlint perl-Wx-Scintilla.spec > ../SRPMS/perl-Wx-Scintilla-0.34-1.fc17.src.rpm > ../RPMS/x86_64/perl-Wx-Scintilla-* > perl-Wx-Scintilla.spec:22: W: comparison-operator-in-deptoken font(:lang=en) > perl-Wx-Scintilla.src: W: spelling-error Summary(en_US) wxWidgets -> caskets, > gaskets, casket's > perl-Wx-Scintilla.src: W: spelling-error %description -l en_US StyledTextCtrl > perl-Wx-Scintilla.src: W: spelling-error %description -l en_US wxWidgets -> > caskets, gaskets, casket's > perl-Wx-Scintilla.src: W: spelling-error %description -l en_US timeline -> time > line, time-line, timberline > perl-Wx-Scintilla.src:22: W: comparison-operator-in-deptoken font(:lang=en) > perl-Wx-Scintilla.x86_64: W: spelling-error Summary(en_US) wxWidgets -> > caskets, gaskets, casket's > perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US > StyledTextCtrl > perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US wxWidgets -> > caskets, gaskets, casket's > perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US timeline -> > time line, time-line, timberline > perl-Wx-Scintilla.x86_64: W: private-shared-object-provides > /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so > Scintilla.so()(64bit) > perl-Wx-Scintilla.x86_64: W: private-shared-object-provides > /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so > libwx_gtk2u_scintilla-2.8.so()(64bit) > perl-Wx-Scintilla.x86_64: W: private-shared-object-provides > /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so > Scintilla.so()(64bit) > perl-Wx-Scintilla.x86_64: W: private-shared-object-provides > /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so > libwx_gtk2u_scintilla-2.8.so()(64bit) > perl-Wx-Scintilla.x86_64: E: binary-or-shlib-defines-rpath > /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/ ['$ORIGIN'] > perl-Wx-Scintilla-debuginfo.x86_64: E: debuginfo-without-sources > 3 packages and 1 specfiles checked; 2 errors, 14 warnings. > > FIX: Do not provide private libraries (unbundle or use %perl_default_filter). Filter is used. > FIX: Do not set RPATH in Scintilla.so (unbundle or use > LDFLAGS+=--enable-new-dtags to convert RPATH to RUN_PATH). I guess RPATH is not a problem here. They are using the bundled version, so they want to use this specific Scintilla.so. > > TODO: You can package some tools/*. Not sure if they are useful. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review