Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757657 --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-01-03 11:51:42 EST --- Spec file changes: --- perl-Wx-Scintilla.spec 2011-11-28 11:00:50.000000000 +0100 +++ perl-Wx-Scintilla.spec.1 2012-01-02 16:58:24.000000000 +0100 @@ -4,17 +4,33 @@ Version: 0.34 Release: 1%{?dist} Summary: Scintilla source code editing component for wxWidgets -License: GPL+ or Artistic +# details of licenses: +# wx-scintilla is bundle of scintilla under wxwindows +# wx-scintilla/src/scintilla/src is copy of files from scintilla/{lexers,lexlib,src} +# wx-scintilla/src/scintilla/include contains upstream scintilla/include without *.py file +# wx-scintilla/src/scintilla/License.txt is MIT +# wx-scintilla/include files are marked as wxWindows license +# According to email with upstream the bundle is necessary, because every project needs +# modify scintilla for their own use. +License: (GPL+ or Artistic) and MIT and wxWidgets Group: Development/Libraries URL: http://search.cpan.org/dist/Wx-Scintilla/ Source0: http://www.cpan.org/authors/id/A/AZ/AZAWAWI/Wx-Scintilla-%{version}.tar.gz BuildRequires: perl(Alien::wxWidgets) +BuildRequires: perl(Carp) +BuildRequires: perl(Exporter) BuildRequires: perl(ExtUtils::XSpp) >= 0.1602 BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) BuildRequires: perl(Wx) +BuildRequires: perl(XSLoader) # tests BR BuildRequires: wxGTK-devel, gtk2-devel +BuildRequires: perl(base) +BuildRequires: perl(Wx::App) +BuildRequires: perl(Wx::Frame) +BuildRequires: perl(Wx::Event) +BuildRequires: perl(lib) %if %{use_x11_tests} # X11 tests: BuildRequires: xorg-x11-server-Xvfb @@ -26,18 +42,26 @@ %description While we already have a good scintilla editor component support via -Wx::StyledTextCtrl in Perl, we already suffer from an older scintilla -package and thus lagging Perl support in the popular Wx Scintilla -component. wxWidgets http://wxwidgets.org has a *very slow* release -timeline. Scintilla is a contributed project which means it will not be the -latest by the time a new wxWidgets distribution is released. And on the -scintilla front, the Perl 5 lexer is not 100% bug free even and we do not -have any kind of Perl 6 support in Scintilla. +Wx::StyledTextCtrl in Perl, we already suffer from an older scintilla package +and thus lagging Perl support in the popular Wx Scintilla component. wxWidgets +L<http://wxwidgets.org> has a *very slow* release timeline. Scintilla is a +contributed project which means it will not be the latest by the time a new +wxWidgets distribution is released. And on the scintilla front, the Perl 5 lexer +is not 100% bug free even and we do not have any kind of Perl 6 support in +Scintilla. + +The ambitious goal of this project is to provide fresh Perl 5 and maybe 6 +support in L<Wx> while preserving compatibility with Wx::StyledTextCtrl +and continually contribute it back to Scintilla project. + +%{?perl_default_filter} %prep %setup -q -n Wx-Scintilla-%{version} +rm -rf ./Wx-Scintilla-%{version}/wx-scintilla %build +export LDFLAGS=--enable-new-dtags %{__perl} Build.PL installdirs=vendor optimize="$RPM_OPT_FLAGS" ./Build @@ -59,7 +83,7 @@ %endif %files -%doc Changes META.json README Scintilla_README +%doc Changes README Scintilla_README %{perl_vendorarch}/auto/* %{perl_vendorarch}/Wx* %{_mandir}/man3/* > FIX: License tag does not cover bundled Scintilla sources > (wx-scintilla/src/scintilla/). -License: GPL+ or Artistic +# details of licenses: +# wx-scintilla is bundle of scintilla under wxwindows +# wx-scintilla/src/scintilla/src is copy of files from scintilla/{lexers,lexlib,src} +# wx-scintilla/src/scintilla/include contains upstream scintilla/include without *.py file +# wx-scintilla/src/scintilla/License.txt is MIT +# wx-scintilla/include files are marked as wxWindows license +# According to email with upstream the bundle is necessary, because every project needs +# modify scintilla for their own use. +License: (GPL+ or Artistic) and MIT and wxWidgets FIX: wx-scintilla/src/scintilla/License.txt looks like MIT but it is not exact copy of any wordings from <https://fedoraproject.org/wiki/Licensing/MIT>. Please get confirmation by Fedora legal department. Scintiall variant should appear on the web page. > > FIX: Do not bundle Scintilla (wx-scintilla/src/scintilla/). > Scintilla must be bundled. FIX: Then you need exception from Fedora Packaging Committee (https://fedoraproject.org/wiki/Packaging:No_Bundled_Libraries#Exceptions). > TODO: Augment description with other paragraphs from lib/Wx/Scintilla.pm POD. > The first one does not define what this package delivers. %description While we already have a good scintilla editor component support via -Wx::StyledTextCtrl in Perl, we already suffer from an older scintilla -package and thus lagging Perl support in the popular Wx Scintilla -component. wxWidgets http://wxwidgets.org has a *very slow* release -timeline. Scintilla is a contributed project which means it will not be the -latest by the time a new wxWidgets distribution is released. And on the -scintilla front, the Perl 5 lexer is not 100% bug free even and we do not -have any kind of Perl 6 support in Scintilla. +Wx::StyledTextCtrl in Perl, we already suffer from an older scintilla package +and thus lagging Perl support in the popular Wx Scintilla component. wxWidgets +L<http://wxwidgets.org> has a *very slow* release timeline. Scintilla is a +contributed project which means it will not be the latest by the time a new +wxWidgets distribution is released. And on the scintilla front, the Perl 5 lexer +is not 100% bug free even and we do not have any kind of Perl 6 support in +Scintilla. + +The ambitious goal of this project is to provide fresh Perl 5 and maybe 6 +support in L<Wx> while preserving compatibility with Wx::StyledTextCtrl +and continually contribute it back to Scintilla project. FIX: Remove POD mark-up from Description text. > FIX: Build-require perl(Exporter) (lib/Wx/Scintilla/Constant.pm:12) +BuildRequires: perl(Exporter) Ok. > FIX: Build-require perl(Caro) (lib/Wx/Scintilla.pm:6) +BuildRequires: perl(Carp) Ok. > FIX: Build-require perl(XSLoader) (lib/Wx/Scintilla.pm:8) +BuildRequires: perl(XSLoader) Ok. > FIX: Build-require perl(base) (t/lib/Tests_Helper.pm:197) +BuildRequires: perl(base) Ok. > FIX: Build-require perl(Wx::App) (t/lib/Tests_Helper.pm:197) +BuildRequires: perl(Wx::App) Ok. > FIX: Build-require perl(Wx::Frame) (t/lib/Tests_Helper.pm:218) +BuildRequires: perl(Wx::Frame) Ok. > FIX: Build-require perl(Wx::Event) (t/03_editor.t:27) +BuildRequires: perl(Wx::Event) Ok. > FIX: Build-require perl(lib) (t/02_inheritance.t:10) +BuildRequires: perl(lib) Ok. > TODO: Do not %doc-package META.json (as you do not package META.yml) %files -%doc Changes META.json README Scintilla_README +%doc Changes README Scintilla_README Ok. $ rpmlint perl-Wx-Scintilla.spec ../SRPMS/perl-Wx-Scintilla-0.34-1.fc17.src.rpm ../RPMS/x86_64/perl-Wx-Scintilla-* perl-Wx-Scintilla.spec:38: W: comparison-operator-in-deptoken font(:lang=en) perl-Wx-Scintilla.src: W: spelling-error Summary(en_US) wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.src: W: spelling-error %description -l en_US StyledTextCtrl perl-Wx-Scintilla.src: W: spelling-error %description -l en_US wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.src: W: spelling-error %description -l en_US http -> HTTP, HP, HT perl-Wx-Scintilla.src: W: spelling-error %description -l en_US wxwidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.src: W: spelling-error %description -l en_US timeline -> time line, time-line, timberline perl-Wx-Scintilla.src:38: W: comparison-operator-in-deptoken font(:lang=en) perl-Wx-Scintilla.x86_64: W: spelling-error Summary(en_US) wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US StyledTextCtrl perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US http -> HTTP, HP, HT perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US wxwidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US timeline -> time line, time-line, timberline perl-Wx-Scintilla.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so ['$ORIGIN'] perl-Wx-Scintilla-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 1 specfiles checked; 2 errors, 14 warnings. > FIX: Do not provide private libraries (unbundle or use %perl_default_filter). +%{?perl_default_filter} Ok. > > FIX: Do not set RPATH in Scintilla.so (unbundle or use > > LDFLAGS+=--enable-new-dtags to convert RPATH to RUN_PATH). > I guess RPATH is not a problem here. They are using the bundled version, so > they want to use this specific Scintilla.so. RPATH cannot be overridden by environment variables (if requested by user) in contrast to RUN_PATH. Thus converting RPATH to RUN_PATH is good. Apparently the LDFLAGS value did not pass to linker. However this is not blocker, especially if the second library is in private directory. So you can remove the useless variable export. $ rpm -q --provides -p ../RPMS/x86_64/perl-Wx-Scintilla-0.34-1.fc17.x86_64.rpm perl(Wx::Scintilla) = 0.34 perl(Wx::Scintilla::Constant) = 0.34 perl(Wx::Scintilla::Manual) perl(Wx::Scintilla::TextCtrl) = 0.34 perl(Wx::Scintilla::TextEvent) = 0.34 perl(Wx::ScintillaTextCtrl) = 0.34 perl(Wx::ScintillaTextEvent) = 0.34 perl-Wx-Scintilla = 0.34-1.fc17 perl-Wx-Scintilla(x86-64) = 0.34-1.fc17 Binary provides are Ok. Please correct all `FIX' prefixed issues, get exception from FPC and provide new spec file. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review