Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=757657 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> 2011-11-28 07:14:42 EST --- Source tar ball is original. Ok. Summary verified from lib/Wx/Scintilla.pm. Ok. FIX: License tag does not cover bundled Scintilla sources (wx-scintilla/src/scintilla/). FIX: Do not bundle Scintilla (wx-scintilla/src/scintilla/). TODO: Augment description with other paragraphs from lib/Wx/Scintilla.pm POD. The first one does not define what this package delivers. FIX: Build-require perl(Exporter) (lib/Wx/Scintilla/Constant.pm:12) FIX: Build-require perl(Caro) (lib/Wx/Scintilla.pm:6) FIX: Build-require perl(XSLoader) (lib/Wx/Scintilla.pm:8) FIX: Build-require perl(base) (t/lib/Tests_Helper.pm:197) FIX: Build-require perl(Wx::App) (t/lib/Tests_Helper.pm:197) FIX: Build-require perl(Wx::Frame) (t/lib/Tests_Helper.pm:218) FIX: Build-require perl(Wx::Event) (t/03_editor.t:27) FIX: Build-require perl(lib) (t/02_inheritance.t:10) TODO: Do not %doc-package META.json (as you do not package META.yml) All tests pass. Ok. $ rpmlint perl-Wx-Scintilla.spec ../SRPMS/perl-Wx-Scintilla-0.34-1.fc17.src.rpm ../RPMS/x86_64/perl-Wx-Scintilla-* perl-Wx-Scintilla.spec:22: W: comparison-operator-in-deptoken font(:lang=en) perl-Wx-Scintilla.src: W: spelling-error Summary(en_US) wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.src: W: spelling-error %description -l en_US StyledTextCtrl perl-Wx-Scintilla.src: W: spelling-error %description -l en_US wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.src: W: spelling-error %description -l en_US timeline -> time line, time-line, timberline perl-Wx-Scintilla.src:22: W: comparison-operator-in-deptoken font(:lang=en) perl-Wx-Scintilla.x86_64: W: spelling-error Summary(en_US) wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US StyledTextCtrl perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US wxWidgets -> caskets, gaskets, casket's perl-Wx-Scintilla.x86_64: W: spelling-error %description -l en_US timeline -> time line, time-line, timberline perl-Wx-Scintilla.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so Scintilla.so()(64bit) perl-Wx-Scintilla.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so libwx_gtk2u_scintilla-2.8.so()(64bit) perl-Wx-Scintilla.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so Scintilla.so()(64bit) perl-Wx-Scintilla.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so libwx_gtk2u_scintilla-2.8.so()(64bit) perl-Wx-Scintilla.x86_64: E: binary-or-shlib-defines-rpath /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/ ['$ORIGIN'] perl-Wx-Scintilla-debuginfo.x86_64: E: debuginfo-without-sources 3 packages and 1 specfiles checked; 2 errors, 14 warnings. FIX: Do not provide private libraries (unbundle or use %perl_default_filter). FIX: Do not set RPATH in Scintilla.so (unbundle or use LDFLAGS+=--enable-new-dtags to convert RPATH to RUN_PATH). TODO: You can package some tools/*. $ rpm -q -lv -p ../RPMS/x86_64/perl-Wx-Scintilla-0.34-1.fc17.x86_64.rpm drwxr-xr-x 2 root root 0 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx drwxr-xr-x 2 root root 0 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla -rw-r--r-- 1 root root 14987 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla.pm -rw-r--r-- 1 root root 160579 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla/Constant.pm -rw-r--r-- 1 root root 517 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla/Manual.pod -rw-r--r-- 1 root root 139 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla/TextCtrl.pm -rw-r--r-- 1 root root 141 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/Wx/Scintilla/TextEvent.pm drwxr-xr-x 2 root root 0 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/auto/Wx drwxr-xr-x 2 root root 0 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla -rwxr-xr-x 1 root root 432240 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/Scintilla.so -rwxr-xr-x 1 root root 2276232 Nov 28 12:06 /usr/lib64/perl5/vendor_perl/auto/Wx/Scintilla/libwx_gtk2u_scintilla-2.8.so drwxr-xr-x 2 root root 0 Nov 28 12:06 /usr/share/doc/perl-Wx-Scintilla-0.34 -rw-r--r-- 1 root root 10463 Nov 2 12:51 /usr/share/doc/perl-Wx-Scintilla-0.34/Changes -rw-r--r-- 1 root root 2012 Nov 2 12:51 /usr/share/doc/perl-Wx-Scintilla-0.34/META.json -rw-r--r-- 1 root root 1557 Nov 2 12:51 /usr/share/doc/perl-Wx-Scintilla-0.34/README -rw-r--r-- 1 root root 2496 Nov 2 12:51 /usr/share/doc/perl-Wx-Scintilla-0.34/Scintilla_README -rw-r--r-- 1 root root 5186 Nov 28 12:06 /usr/share/man/man3/Wx::Scintilla.3pm.gz -rw-r--r-- 1 root root 16800 Nov 28 12:06 /usr/share/man/man3/Wx::Scintilla::Constant.3pm.gz -rw-r--r-- 1 root root 1931 Nov 28 12:06 /usr/share/man/man3/Wx::Scintilla::Manual.3pm.gz File layout an permission Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Wx-Scintilla-0.[test@fedora-17 SPECS]$ rpm -q --requires -p ../RPMS/x86_64/perl-Wx-Scintilla-0.34-1.fc17.x86_64.rpm |sort |uniq -c 1 libatk-1.0.so.0()(64bit) 1 libcrypt.so.1()(64bit) 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.14)(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6(GLIBC_2.3)(64bit) 1 libdl.so.2()(64bit) 1 libfontconfig.so.1()(64bit) 1 libfreetype.so.6()(64bit) 1 libgcc_s.so.1()(64bit) 1 libgcc_s.so.1(GCC_3.0)(64bit) 1 libgdk_pixbuf-2.0.so.0()(64bit) 1 libgdk-x11-2.0.so.0()(64bit) 1 libglib-2.0.so.0()(64bit) 1 libgmodule-2.0.so.0()(64bit) 1 libgobject-2.0.so.0()(64bit) 1 libgthread-2.0.so.0()(64bit) 1 libgtk-x11-2.0.so.0()(64bit) 1 libm.so.6()(64bit) 1 libnsl.so.1()(64bit) 1 libpango-1.0.so.0()(64bit) 1 libpangoft2-1.0.so.0()(64bit) 1 libpng15.so.15()(64bit) 1 libpthread.so.0()(64bit) 1 libpthread.so.0(GLIBC_2.2.5)(64bit) 1 libresolv.so.2()(64bit) 1 librt.so.1()(64bit) 1 libstdc++.so.6()(64bit) 1 libstdc++.so.6(CXXABI_1.3)(64bit) 1 libstdc++.so.6(GLIBCXX_3.4)(64bit) 1 libutil.so.1()(64bit) 1 libwx_baseu-2.8.so.0()(64bit) 1 libwx_baseu-2.8.so.0(WXU_2.8)(64bit) 1 libwx_gtk2u_core-2.8.so.0()(64bit) 1 libwx_gtk2u_core-2.8.so.0(WXU_2.8)(64bit) 1 libwx_gtk2u_scintilla-2.8.so()(64bit) 1 libz.so.1()(64bit) 1 perl >= 0:5.008 1 perl(Carp) 1 perl(constant) 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(Wx) 1 perl(Wx::Scintilla::Constant) 1 perl(Wx::Scintilla::TextCtrl) 1 perl(Wx::Scintilla::TextEvent) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Wx-Scintilla-0.34-1.fc17.x86_64.rpm |sort |uniq -c 1 libwx_gtk2u_scintilla-2.8.so()(64bit) 1 perl(Wx::Scintilla) = 0.34 1 perl-Wx-Scintilla = 0.34-1.fc17 1 perl(Wx::Scintilla::Constant) = 0.34 1 perl(Wx::Scintilla::Manual) 1 perl(Wx::Scintilla::TextCtrl) = 0.34 1 perl(Wx::ScintillaTextCtrl) = 0.34 1 perl(Wx::Scintilla::TextEvent) = 0.34 1 perl(Wx::ScintillaTextEvent) = 0.34 1 perl-Wx-Scintilla(x86-64) = 0.34-1.fc17 1 Scintilla.so()(64bit) FIX: Do not export private libwx_gtk2u_scintilla-2.8.so()(64bit). $ resolvedeps rawhide ../RPMS/x86_64/perl-Wx-Scintilla-0.34-1.fc17.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F17 (http://koji.fedoraproject.org/koji/taskinfo?taskID=3546038). Ok. Package is in line with Perl packaging guidelines. Package does not conform to Fedora packaging guidelines: Bundles library. Correct all `FIX' prefixed issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review