Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758734 --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> 2011-12-12 14:13:47 EST --- Concerning the name macro: I recently discovered spectool. Spectool substitutes the macros and prints the result. The guidelines don't force you to use it, so it's up to you. Though, in your case, the name is pretty long and I can't see a potential disadvantage. Is there something wrong with the locales? I see they're not installed. OK, I'm fine with the comment in the diff. It's a "SHOULD": http://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment I meant to add the %docdir comment in the spec file, not here. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review