Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758734 --- Comment #4 from Jan Vcelak <jvcelak@xxxxxxxxxx> 2012-02-08 09:29:34 EST --- Sorry for the delay. Spec URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/1.2.0-0.2.beta1/fatrat-subtitlesearch.spec SRPM URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/fatrat-subtitlesearch-1.2.0-0.2.beta1.fc17.src.rpm > Concerning the name macro: I recently discovered spectool. Spectool substitutes > the macros and prints the result. The guidelines don't force you to use it, so > it's up to you. Though, in your case, the name is pretty long and I can't see a > potential disadvantage. OK, I've added the macro. > Is there something wrong with the locales? I see they're not installed. Hmm, missing cmake flag. Fixed now. > I meant to add the %docdir comment in the spec file, not here. :) It's there now. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review