Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=758734 --- Comment #2 from Jan Vcelak <jvcelak@xxxxxxxxxx> 2011-12-12 08:23:26 EST --- Spec URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/1.2.0-0.1.beta1/fatrat-subtitlesearch.spec SRPM URL (updated): http://jvcelak.fedorapeople.org/review/fatrat-subtitlesearch/fatrat-subtitlesearch-1.2.0-0.1.beta1.fc17.src.rpm > * Package doesn't build on F16 The build depends on the new version of fatrat, which is not in stable updates yet. Therefore you need to install fatrat-devel manually into your build environment. I have crated a build override in Koji, so it builds in Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=3579585 > * "Beta" must be in release, not version: > http://fedoraproject.org/wiki/Packaging:NamingGuidelines#Pre-Release_packages Thank you for catching this. I didn't know that. It is fixed now. > * Drop the version requirement on Qt, we don't have versions older than 4.5 Done. > * The files indicate GPLv2, not v2+ You are right. Fixed. > * You can use the name macro in Source0 and in the files section Well, I left this untouched because I think this is more readable. > * Please add a comment on what your patch does and why you're deleting _docdir I always put comments in the patch headers. So it is here. %{_docdir} is deleted because upstream installs it into a wrong subdirectory. All documentation is installed later in %files section into correct location. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review