Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706432 --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> 2011-12-10 18:50:44 EST --- If you understand what the code is supposed to do, please try to correct: aggregate.c:257:9: warning: suggest parentheses around '&&' within '||' [-Wparentheses] Please write a comment on the patch in the spec file. Something like: "Adjust installation to use DESTDIR and preserve manpage timestamps" You could also change the name of the patch to something more self-explanatory. The sub-package's require should look like this: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package If you don't have a good reason not to, use the name macro in the Source0 and Patch0 line. Also use it in the files section. (You can delete the trailing slash on the URL line, if you want.) Yes, asteriSK, of course! :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review