Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706432 --- Comment #4 from Yanko Kaneti <yaneti@xxxxxxxxxxx> 2011-12-11 05:08:09 EST --- - I'd rather not get into code at the time of review - I think "-fedora" is pretty much self explanatory for both the patch and the changes it does. Basically changes specific to fedora that don't alter the main functionality of the program or fix specific upstream bugs. No need to go into details. - I don't think the requires is all that specific. What the perl script wants is to run a binary called aggregate. - The %{name} macro use is just pedantry with little practical value ihmo. Thanks -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review