Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=706432 --- Comment #2 from Yanko Kaneti <yaneti@xxxxxxxxxxx> 2011-12-09 17:04:13 EST --- (In reply to comment #1) Thanks for the review. > licensecheck finds the license to be ISC. Obviously BSD type licenses confuse me. Didn't know about licensecheck. > What does "aggregate(1)" mean in the ios description? I guess it means aggregate in man section 1, as most commands are usually referred in documentation. But I guess not necessary here. I've removed it. > You don't need to include the license file and history in the sub-package, as > it requires the main package. Removed. > Better use an asterix instead of "gz" in the files section. Changed to asterisk. > The manpages should be installed with -p. Added a -p. 1.6-2 - Some changes suggested by review comment #1 Spec URL: http://declera.com/~yaneti/aggregate/aggregate.spec SRPM URL: http://declera.com/~yaneti/aggregate/aggregate-1.6-2.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review