[Bug 725552] Review Request: confparse - A KISS parse to *nix config files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=725552

--- Comment #4 from Jussi Lehtola <jussi.lehtola@xxxxxx> 2011-07-26 15:16:13 EDT ---
Looks better. I would've used just "python", since IMHO %{__python} is
overkill. Although it's allowed by rpm, I don't think there's much sense in
using macros such as %{__cp}, %{__mv}, %{__rm}, %{__mkdir} and so on.

You seem to have a tab stop problem with BuildArch now, otherwise things are
probably OK.

Now you'll just have to wait for Rafael to do his review.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]