Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=725552 --- Comment #5 from Rafael Aquini <aquini@xxxxxxxxx> 2011-07-26 18:27:18 EDT --- Howdy folks! Jussi: Thanks for doing this pre-review. It has made my work a lot easier. Douglas: Please, consider the following formal review: Good: * rpmlint runs on the source rpm and all binary rpms the build produces. Warnings, and error reported are common false positives, and should be ignored: ** [raquini@optiplex ~]$ rpmlint rpmbuild/SPECS/confparse.spec /home/aquini/rpmbuild/SRPMS/confparse-1.0.0-2.fc14.src.rpm /home/aquini/rpmbuild/RPMS/noarch/confparse-1.0.0-2.fc14.noarch.rpm confparse.src: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure confparse.src: W: spelling-error %description -l en_US config -> con fig, con-fig, configure confparse.src: W: file-size-mismatch confparse-1.0.0.tar.gz = 14371, https://github.com/dougsland/confparse/raw/master/confparse-1.0.0.tar.gz = 1 confparse.noarch: W: spelling-error Summary(en_US) config -> con fig, con-fig, configure confparse.noarch: W: spelling-error %description -l en_US config -> con fig, con-fig, configure confparse.noarch: E: non-executable-script /usr/lib/python2.7/site-packages/confparse.py 0644L /usr/bin/python 2 packages and 1 specfiles checked; 1 errors, 5 warnings. * License in spec and sources is LGPLv2+ which is open source * Spec is legible and American English * Source matches upstream ** wget https://github.com/dougsland/confparse/raw/master/confparse-1.0.0.tar.gz **[raquini@optiplex ~]$ md5sum confparse-1.0.0.tar.gz rpmbuild/SOURCES/confparse-1.0.0/confparse-1.0.0.tar.gz 08601828f09b97ec4629539dbb893450 confparse-1.0.0.tar.gz 08601828f09b97ec4629539dbb893450 rpmbuild/SOURCES/confparse-1.0.0/confparse-1.0.0.tar.gz * No locale files * No shared libraries * No bundled libraries * Not relocatable * No directories created unowned * No duplicate files * Default permissions are set * Package is code * No large documentation * No %doc files are used at runtime * No header files * Not a GUI application * Does not own files or directories from other packages * All filenames are utf8 * Builds in mock * Builds in koji: [raquini@optiplex ~]$ koji build --scratch dist-rawhide /var/lib/mock/fedora-14-x86_64/result/confparse-1.0.0-2.fc14.src.rpm Uploading srpm: /var/lib/mock/fedora-14-x86_64/result/confparse-1.0.0-2.fc14.src.rpm [====================================] 100% 00:00:02 17.32 KiB 7.11 KiB/sec Created task: 3232534 Task info: http://koji.fedoraproject.org/koji/taskinfo?taskID=3232534 Watching tasks (this may be safely interrupted)... 3232534 build (dist-rawhide, confparse-1.0.0-2.fc14.src.rpm): free 3232534 build (dist-rawhide, confparse-1.0.0-2.fc14.src.rpm): free -> open (x86-02.phx2.fedoraproject.org) 3232535 waitrepo (191): open (x86-04.phx2.fedoraproject.org) 3232542 buildArch (confparse-1.0.0-2.fc14.src.rpm, noarch): open (x86-03.phx2.fedoraproject.org) 3232535 waitrepo (191): open (x86-04.phx2.fedoraproject.org) -> closed 0 free 2 open 1 done 0 failed 3232542 buildArch (confparse-1.0.0-2.fc14.src.rpm, noarch): open (x86-03.phx2.fedoraproject.org) -> closed 0 free 1 open 2 done 0 failed 3232534 build (dist-rawhide, confparse-1.0.0-2.fc14.src.rpm): open (x86-02.phx2.fedoraproject.org) -> closed 0 free 0 open 3 done 0 failed 3232534 build (dist-rawhide, confparse-1.0.0-2.fc14.src.rpm) completed successfully NEEDSWORK: [1] As your package is enhancing, or adding new functionality to, an existing Fedora package (python) without being useful on its own, it is considered an "addon" package. So, its name should reflect this fact. Said that, your package should be renamed to python-confparse, or pyconfparse, according to the Package Naming Guidelines: http://fedoraproject.org/wiki/Packaging/NamingGuidelines#Addon_Packages_.28python_modules.29 [2] Fix that last Jussi's observation on BuildArch: header alignment. As soon as you have this work done I'll grant your package approval. Cheers! --Aquini -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review