Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #17 from Damian L Brasher <fedora@xxxxxxxxxxxxxxxxx> 2011-07-25 15:43:36 EDT --- Thanks Martin. I have added a changelog entry to record today's changes. If I understand correctly, the package is not yet built, so I can reset the version release with a new entry. %changelog * Mon Jul 25 2011 Damian L Brasher <dlb@xxxxxxxxxxxxxxxx> 1.1.0-1 - Red Hat Bugzilla Bug 644711 Review Request, Comments #12,#14 & #16. * Mon Apr 18 2011 Damian L Brasher <dlb@xxxxxxxxxxxxxxxx> 1.1.0-1 - Updated to release 1.1.0. ... - %defattr(-,root,root,-) is at the top of the %files section - EPEL4 is a potential release channel. EPEL < 6 may be considered, so I'll leave the optional items in place for now. - I have commented out the now empty (to test with rpm -qRp) Requires tag. This is the result after rpmbuild: [makerpm@fedora15 noarch]$ rpm -qRp diaser-1.1.0-1.fc15.noarch.rpm /usr/bin/perl perl >= 0:5.008_008 perl(AppConfig) perl(Carp) perl(Data::Password) perl(English) perl(File::Find) perl(Getopt::Long) perl(Net::SFTP) perl(Net::SSH::Perl) perl(Term::ReadKey) perl(Time::HiRes) perl(strict) perl(warnings) rpmlib(CompressedFileNames) <= 3.0.4-1 rpmlib(FileDigests) <= 4.6.0-1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 rpmlib(PayloadIsXz) <= 5.2-1 How do I reform the Requires tag contents with the above? These URL's have been updated (I'll ensure they are kept update with the completed Requires tag): SPEC URL: http://diaser.git.sourceforge.net/git/gitweb.cgi?p=diaser/diaser;a=blob_plain;f=diaser.spec;hb=HEAD SRPM URL: http://sourceforge.net/projects/diaser/files/diaser/1.1.0-beta3-dev/diaser-1.1.0-1.fc15.src.rpm Review practice: ---------------- I have completed an initial review of bug #705319 Understood that I will review, in detail, two more uncommented review request not blocked by FE-NEEDSPONSOR. Best Damian -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review