Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684938 --- Comment #4 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-07-25 15:41:51 EDT --- After looking into things a bit more I noticed a few other issues. 4. There are no files in the wmdrawer-debuginfo package. The reason is that the Makefile is using "strip" to remove the debugging symbols. There's no flag to pass to stop that behavior so I fixed it with sed as follows: # Prevent the Makefile from stripping the binaries # Otherwise there are no debugging symbols sed -i '/strip/d' Makefile 5. The makefile is not honoring your "OPTS" argument to make. I tried changing it to CFLAGS but that broke compiling because it replaced CFLAGS in the makefile instead of adding to it. I fixed that as follows: # Patch the Makefile so that CFLAGS are added not replaced. sed -i 's/CFLAGS =/override CFLAGS +=/g' Makefile Then updated your make command to: make -L CFLAGS='%{optflags}' %{?_smp_mflags} 6. Not really a problem but you could (if you wanted to) replace the last two arguments to %doc with: doc/*.smgl That's it as far as I know. I'll probably run it through the packaging guidelines tomorrow. Here's a link to the updated spec if you want to use it: http://hobbes1069.fedorapeople.org/wmdrawer.spec Richard -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review