Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=684938 Richard Shaw <hobbes1069@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hobbes1069@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |hobbes1069@xxxxxxxxx Flag| |fedora-review? --- Comment #3 from Richard Shaw <hobbes1069@xxxxxxxxx> 2011-07-25 15:28:42 EDT --- Ok, first things first! :) Looking at the spec file you're copying INSTALL with the %doc's. I've noticed several packages do this but you don't need the install directions since we're building a binary package, also, the guidelines say to leave it out. I built the package under mock for F14 x86_64 and I get the following rpmlint output: """ $ rpmlint *.rpm wmdrawer.src: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, dockage wmdrawer.src: I: enchant-dictionary-not-found de wmdrawer.src: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, dockage wmdrawer.src: W: spelling-error %description -l en_US usr -> use, us, user wmdrawer.src: W: file-size-mismatch wmdrawer-0.10.5.tar.gz = 49109, http://people.easter-eggs.org/~valos/wmdrawer/wmdrawer-0.10.5.tar.gz = 49479 wmdrawer.x86_64: W: spelling-error Summary(en_US) dockapp -> dock app, dock-app, dockage wmdrawer.x86_64: W: spelling-error %description -l en_US dockapp -> dock app, dock-app, dockage wmdrawer.x86_64: W: file-not-utf8 /usr/share/doc/wmdrawer-0.10.5/ChangeLog wmdrawer.x86_64: W: wrong-file-end-of-line-encoding /usr/share/doc/wmdrawer-0.10.5/wmdrawer-it.sgml wmdrawer.x86_64: W: file-not-utf8 /usr/share/doc/wmdrawer-0.10.5/wmdrawer-it.sgml wmdrawer.x86_64: W: file-not-utf8 /usr/share/doc/wmdrawer-0.10.5/AUTHORS wmdrawer.x86_64: E: incorrect-fsf-address /usr/share/doc/wmdrawer-0.10.5/COPYING wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/graphics.c wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/config.c wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/utils.c wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/images.c wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/types_defs.h wmdrawer-debuginfo.x86_64: E: incorrect-fsf-address /usr/src/debug/wmdrawer-0.10.5/wmdrawer.c 3 packages and 0 specfiles checked; 7 errors, 10 warnings. """ 1. Problem: The file-size-mismatch. Did you alter the source archive? Or maybe upstream tweaked something without creating a new version? 2. All the wrong-file-end-of-line-encoding and file-not-utf8 errors should probably be fixed with "dos2linux -k <file>" after "make install". 3. The incorrect-fsf-address is nothing you can fix but should be reported upstream. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review