Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=644711 --- Comment #18 from Martin Gieseking <martin.gieseking@xxxxxx> 2011-07-25 17:34:53 EDT --- Hello Damian, (In reply to comment #17) > I have added a changelog entry to record today's changes. If I understand > correctly, the package is not yet built, so I can reset the version release > with a new entry. Sorry if my previous comment was a bit unclear. As long as the version number doesn't change, you should update the release number every time you provide a new revision of the package. It doesn't matter whether it has already been build or not. If the version increases because of a new upstream release, update the version number and reset the release number back to 1. Thus, the combination %{version}-%{release} should strictly increase with every new package revision. Your latest revision should be 1.1.0-2, the next one is 1.1.0-3, etc. If you release 1.2.0, the release number goes back to 1: 1.2.0-1. > %changelog > * Mon Jul 25 2011 Damian L Brasher <dlb@xxxxxxxxxxxxxxxx> 1.1.0-1 > - Red Hat Bugzilla Bug 644711 Review Request, Comments #12,#14 & #16. > > * Mon Apr 18 2011 Damian L Brasher <dlb@xxxxxxxxxxxxxxxx> 1.1.0-1 > - Updated to release 1.1.0. The latest %changelog entry documents revision 1.1.0-2, so update the release number there as well. > [makerpm@fedora15 noarch]$ rpm -qRp diaser-1.1.0-1.fc15.noarch.rpm > How do I reform the Requires tag contents with the above? This rpm command lists all dependencies ("Requires") of the package. As you can see, rpmbuild detected all required Perl modules automatically, so you don't need to state them in the spec file at all. If anything were missing in the list, you would have to add an explicit Requires in the spec like this for example: Requires: perl(Net::SFTP). > I have completed an initial review of bug #705319 OK, you posted the output of rpmlint, that's a first step but not a complete review yet. ;) Please have a look at the MUST and SHOULD items on this wikipage: https://fedoraproject.org/wiki/Packaging:ReviewGuidelines During a review you must check all this items and post your results into the bugzilla ticket (similar to my comment #16 above). Please try to verify all the items for bug #705319. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review