Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719067 --- Comment #2 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-07-14 16:19:33 EDT --- Overall looks good, koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 A few specific nuances though: - please replace all the %defines at the top w/ %globals http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define - please enable --ri documentaion on the gem install command - lib/hmac.rb is licensed under the ruby license and thus the package license must be set to MIT and Ruby accordingly - please mark the test directory as %doc - since the test directory is included, it wouldn't be a bad idea to include a %check section to run the suite - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed here http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review