Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719067 --- Comment #3 from Chris Lalancette <clalance@xxxxxxxxxx> 2011-07-19 13:56:08 EDT --- (In reply to comment #2) > Overall looks good, koji build is green: > > http://koji.fedoraproject.org/koji/taskinfo?taskID=3199493 > > A few specific nuances though: > > - please replace all the %defines at the top w/ %globals > > http://fedoraproject.org/wiki/Packaging/Guidelines#.25global_preferred_over_.25define Oops, fixed. > > > - please enable --ri documentaion on the gem install command Done, but the use of --ri is very inconsistent in Fedora. Many packages don't have it, but some do. > > - lib/hmac.rb is licensed under the ruby license and thus the package license > must be set to MIT and Ruby accordingly Fixed. > > - please mark the test directory as %doc Fixed. > > - since the test directory is included, it wouldn't be a bad idea to include a > %check section to run the suite Fixed. > > - you need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby as instructed > here > > http://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines Done. New SRPM: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac-0.4.0-2.fc14.src.rpm New SPEC: http://people.redhat.com/clalance/rubygem-hmac/rubygem-hmac.spec -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review