Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=719975 Mo Morsi <mmorsi@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag| |fedora-review? --- Comment #2 from Mo Morsi <mmorsi@xxxxxxxxxx> 2011-07-14 17:40:18 EDT --- Overall looks good. Koji build is green: http://koji.fedoraproject.org/koji/taskinfo?taskID=3199631 Specific notes: - the requires rubygem(rake) and rubygem(rspec) should be changed to buildrequires. Since the gem ships w/ a spec suite, it should be invoked in a %check section - need a Requires: ruby(abi) = 1.8 and a BuildRequires: ruby - include a "--ri" flag in the gem install command - rpmlint complains about the following hidden files which should be removed: .yardopts, .gitignore, .infinity_test (not sure what the last one is and/or if it's needed) - the following files should be marked as %doc in the %files section: spec/ directory, license, readme, rakefile, chunky_png.gemspec, benchmarks - consider dropping the "also have a look at oilypng..." blurb from the package description -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review