Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flex-old - Legacy version of flex, a tool for creating scanners https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220381 ------- Additional Comments From pmachata@xxxxxxxxxx 2007-01-05 12:17 EST ------- Thanks for input, folks. I posted updated files to the same url. My comments follow. > libfl basically provides a single function The library provides the function 'main'. It's useful for linking with pure scanner, for testing purposes I suppose. I have never used it personally, but it has been part of flex' interface for ages. It technically can be shared, however strange does it look to have a shared library with 'main' inside. If this would be showstopper, I'll make it shared, no problem here. > However, what is an issue, is the name of this library I doubt any package links with -lfl at all. The library is useful for development of lexer. I think it will be more often fired from command line than from script, thus I chose rather less invasive variant "-lfl-compat", as opposed to "-lfl -L/usr/lib/flex-somesuffix". > The makeinstall macro should not be used unless there is no other choice. > Does the preferred "make install DESTDIR=%{buildroot}" not work? No, the Makefile inside the flex-2.5.4a doesn't honor the DESTDIR variable. > installing the info files Got those fixed. There were more problems, such as file names and infodir entry name. > prefer to see the flex's headers [...] installed into a versioned directory Yes, using version number may be better idea. I'll give it a thought. Maybe it would make more sense to rename also the binaries and relevant files. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review