Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Review Request: flex-old - Legacy version of flex, a tool for creating scanners https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=220381 ------- Additional Comments From rc040203@xxxxxxxxxx 2006-12-30 00:31 EST ------- (In reply to comment #6) > This builds fine for me; a few comments: > W: compat-flex devel-file-in-non-devel-package /usr/lib64/libfl-compat.a > Static libraries are generally frowned upon, but I don't know enough about > just how flex is used to say whether this is completely unacceptable. Well, libfl basically provides a single function. One, most real world lex-scanners normally implement themselves (i.e. link against statically) and won't use anyway. However, what is an issue, is the name of this library: libfl-compat.a. This will break all packages because they expect to link against libfl. IMO, it must remain libfl. Similar considerations apply to the location of FlexScanner.h. I.e. instead of playing games with directories named "compat" and renaming libs, I'd prefer to see the flex's headers and link-libraries files (*.h,*.a) to be installed into a versioned directory, e.g. %{libdir}/flex-<version> %{includedir}/flex-<version> -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug, or are watching someone who is. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review