Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 Orcan Ogetbil <oget.fedora@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |oget.fedora@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |oget.fedora@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2011-06-20 00:01:29 EDT --- Here is my review for this - rpmlint output is clean ? The package bundles the rtmidi library. Normally, we do not allow bundled libraries in Fedora. However as far as I remember, the last time we checked (1-2 years ago?), the rtmidi library was not packagable, so we allowed this as an exception. Did you look into this? * The license tag as GPLv3+ is correct, except the bundled rtmidi library is MIT. Depending on the unbundling situation we might need to add MIT to the license tag. ? Should we build this package with jack support? Jack is the most common sound server used in audio production type applications. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review