Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=709180 --- Comment #2 from Orcan Ogetbil <oget.fedora@xxxxxxxxx> 2011-06-20 00:05:23 EDT --- (In reply to comment #1) > * sed -e 's|\;MIDI|\;X-Midi|g' -e 's|\;JACK|\;X-JACK|g' -e > 's|\;ALSA|\;X-ALSA|g' > This should better be > sed -e 's|\;MIDI|\;Midi|g' -e 's|\;JACK|\;X-Jack|g' -e > 's|\;ALSA|\;X-Alsa|g' > for consistency with other packages, and especially the multimedia-menus > package. > > * The desktop file should be installed via desktop-file-install in the %install > section. Please see > http://fedoraproject.org/wiki/Packaging/Guidelines#Desktop_files Just for clarification, the above two issues can be resolved by a single desktop-file-install command at the end of %install section by using --add-category and --remove-category, etc. See $ desktop-file-install --help-all -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review