Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=710917 --- Comment #2 from Robin Lee <robinlee.sysu@xxxxxxxxx> 2011-06-21 09:55:50 EDT --- (In reply to comment #1) > Here is my review for this > - rpmlint output is clean > > ? The package bundles the rtmidi library. Normally, we do not allow bundled > libraries in Fedora. However as far as I remember, the last time we checked > (1-2 years ago?), the rtmidi library was not packagable, so we allowed this as > an exception. Did you look into this? rtmidi library is still not dynamically linkable. > > * The license tag as GPLv3+ is correct, except the bundled rtmidi library is > MIT. Depending on the unbundling situation we might need to add MIT to the > license tag. According to https://fedoraproject.org/wiki/Licensing/FAQ#How_should_I_handle_multiple_licensing_situations.3F , since MIT is compatible with GPL, so only GPL is needed listed. > > ? Should we build this package with jack support? Jack is the most common sound > server used in audio production type applications. I prefer upstream default setting. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review