Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #3 from Daiki Ueno <dueno@xxxxxxxxxx> 2011-05-10 21:39:55 EDT --- Thanks for quick update. Now it looks fine. APPROVED. Minor suggestion related to 3 is that now README.rdoc is not marked as %doc. Perhaps you might want to do something like the following in %files, if you don't think it's too much :) %dir %{geminstdir} %{geminstdir}/lib %doc %{geminstdir}/MIT-LICENSE %doc %{geminstdir}/README.rdoc %{geminstdir}/Rakefile %{geminstdir}/test -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review