Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 --- Comment #4 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2011-05-11 07:27:20 EDT --- (In reply to comment #3) > Thanks for quick update. Now it looks fine. APPROVED. My pleasure, and thank you for reviewing the package so quickly. :) > Minor suggestion related to 3 is that now README.rdoc is not marked as %doc. > Perhaps you might want to do something like the following in %files, if you > don't think it's too much :) > > %dir %{geminstdir} > %{geminstdir}/lib > %doc %{geminstdir}/MIT-LICENSE > %doc %{geminstdir}/README.rdoc > %{geminstdir}/Rakefile > %{geminstdir}/test Not too much at all. I won't claim to be an expert at packaging, so appreciate the tip I've added those changes as part of the first official release. :) -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review