[Bug 703248] Review Request: rubygem-foreigner - Foreign keys for Rails

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=703248

--- Comment #2 from Darryl L. Pierce <dpierce@xxxxxxxxxx> 2011-05-10 08:35:00 EDT ---
(In reply to comment #1)
> I'm taking the review.  You could check:
> 
> http://lukas.zapletalovi.com/2011/01/how-to-prepare-gemfile-package-for.html
> 
> if you use rubygem-gem2rpm in F-14.

Following the steps about removing the build and prep sections results in
additional warnings from rpmlint, so I'm leaving them in for now. Otherwise,
I've followed the suggestions. Thanks. :)

> 1. Use %global instead of %define

Done

> 2. Add "Requires: ruby(abi) = 1.8" as described in the Ruby packaging guideline
> 
> https://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines

Done.

> 3. I get "File listed twice" warning when building
> 
>  warning: File listed twice:
> /usr/lib/ruby/gems/1.8/gems/foreigner-0.9.2/README.rdoc
> 
> This is because of the following lines in %files:
> 
>  %{gemdir}/gems/%{gemname}-%{version}/
>  %doc %{geminstdir}/README.rdoc
> 
> where %{geminstdir} == %{gemdir}/gems/%{gemname}-%{version}/.  You could work
> around this by listing files/dirs under %{geminstdir} individually.

Fixed.

> 4. You can drop preparing/cleaning buildroot

Done.

> 5. License is MIT (not GPLv2+ and Ruby)

Corrected.

> 6. It is recommended to run test suite in %check

I'm working with the upstream to fix his tests, which are currently not working
correctly.

Updated SPEC: http://mcpierce.fedorapeople.org/rpms/rubygem-foreigner.spec
Updated SRPM:
http://mcpierce.fedorapeople.org/rpms/rubygem-foreigner-0.9.2-2.fc14.src.rpm

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]