Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=703248 Daiki Ueno <dueno@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |dueno@xxxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |dueno@xxxxxxxxxx Flag| |fedora-review? --- Comment #1 from Daiki Ueno <dueno@xxxxxxxxxx> 2011-05-10 02:44:42 EDT --- I'm taking the review. You could check: http://lukas.zapletalovi.com/2011/01/how-to-prepare-gemfile-package-for.html if you use rubygem-gem2rpm in F-14. 1. Use %global instead of %define 2. Add "Requires: ruby(abi) = 1.8" as described in the Ruby packaging guideline https://fedoraproject.org/wiki/Packaging:Ruby#Ruby_Packaging_Guidelines 3. I get "File listed twice" warning when building warning: File listed twice: /usr/lib/ruby/gems/1.8/gems/foreigner-0.9.2/README.rdoc This is because of the following lines in %files: %{gemdir}/gems/%{gemname}-%{version}/ %doc %{geminstdir}/README.rdoc where %{geminstdir} == %{gemdir}/gems/%{gemname}-%{version}/. You could work around this by listing files/dirs under %{geminstdir} individually. 4. You can drop preparing/cleaning buildroot 5. License is MIT (not GPLv2+ and Ruby) 6. It is recommended to run test suite in %check -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review