[Bug 698067] Review Request: hiredis - A C client library for redis

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=698067

--- Comment #3 from Shakthi Kannan <shakthimaan@xxxxxxxxx> 2011-05-10 03:11:36 EDT ---
Thanks for your comments. Updated:

SPEC: http://shakthimaan.fedorapeople.org/SPECS/hiredis.spec
SRPM:
http://shakthimaan.fedorapeople.org/SRPMS/hiredis-0.10.0-1.gitdf203bc328.fc14.src.rpm

* The 0.10.0 fails to build, so have updated to hiredis-0.10.0-1.gitdf203bc328.

* Updated use of:

  make install PREFIX=%{buildroot}/%{_prefix}
INSTALL_LIB=%{buildroot}/%{_libdir}

For 64-bit, we need to override LIBRARY_PATH.

* redis is not required to build hiredis, but, only to use it. Hence, have used
Requires.

* Added TODO file as documentation.

$  rpmlint hiredis.spec
hiredis.spec: W: invalid-url Source0: hiredis.gitdf203bc328.tar.bz2
0 packages and 1 specfiles checked; 0 errors, 1 warnings.

$  rpmlint hiredis-0.10.0-1.gitdf203bc328.fc14.src.rpm 
hiredis.src: W: spelling-error Summary(en_US) minimalistic -> minimalist,
Minimalist, minimalism
hiredis.src: W: spelling-error %description -l en_US minimalistic ->
minimalist, Minimalist, minimalism
hiredis.src: W: invalid-url Source0: hiredis.gitdf203bc328.tar.bz2
1 packages and 0 specfiles checked; 0 errors, 3 warnings.

$  rpmlint hiredis-0.10.0-1.gitdf203bc328.fc14.i686.rpm 
hiredis.i686: W: spelling-error Summary(en_US) minimalistic -> minimalist,
Minimalist, minimalism
hiredis.i686: W: spelling-error %description -l en_US minimalistic ->
minimalist, Minimalist, minimalism
hiredis.i686: W: no-manual-page-for-binary hiredis-example
hiredis.i686: W: no-manual-page-for-binary hiredis-test
1 packages and 0 specfiles checked; 0 errors, 4 warnings.

$  rpmlint hiredis-devel-0.10.0-1.gitdf203bc328.fc14.i686.rpm 
1 packages and 0 specfiles checked; 0 errors, 0 warnings.

Successful Koji builds for F-14, F-15, and EL-6:

http://koji.fedoraproject.org/koji/taskinfo?taskID=3062235
http://koji.fedoraproject.org/koji/taskinfo?taskID=3062238
http://koji.fedoraproject.org/koji/taskinfo?taskID=3062241

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review


[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]