Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=697836 --- Comment #2 from Adam Huffman <bloch@xxxxxxxxxxxx> 2011-05-08 08:01:13 EDT --- (In reply to comment #1) > Just some comments: Thanks for looking > > Please include the license file. The postal addresses of the FSF are outdated > in several files. > File included and I'll contact upstream about the out of data FSF address. > Use -p on the install commands, at least for the scripts. One of the scripts > uses the samtools binary, so you'll need an explicit Require on that, as RPM > will only install samtools-libs > Done. > Besides the first part of the package description is pretty generic, it says, > it would contain instructions. I can't see any and especially the mmseq binary > is especially sparse on saying anything. Why does the description not have the > word "Haplotype"? > I was trying to differentiate the description from the summary but have improved it now. > Why did you choose to not install the Perl script? > Fixed. > You might want to add "-b .name_of_the_patch" to the patch macros. Please also > comment on the patches. Done. I've also updated to the latest upstream release. http://verdurin.fedorapeople.org/reviews/mmseq/mmseq.spec http://verdurin.fedorapeople.org/reviews/mmseq/mmseq-0.9.10b-1.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review