Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=691189 Iain Arnell <iarnell@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |iarnell@xxxxxxxxx AssignedTo|nobody@xxxxxxxxxxxxxxxxx |iarnell@xxxxxxxxx Flag| |fedora-review? --- Comment #1 from Iain Arnell <iarnell@xxxxxxxxx> 2011-05-08 08:24:09 EDT --- At first glance, this looks to be mostly okay; just a couple of minor issues. You need to pass CFLAGS="%{?optflags}" to the build. And there is inconsistent use of macros vs variables - but since we don't need to clean buildroot in %install, you can just remove the offending line. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review